Issue #424: Add sampling fraction option for optimization #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osopardo1
reviewed
Sep 23, 2024
src/test/scala/io/qbeast/spark/utils/QbeastOptimizeIntegrationTest.scala
Outdated
Show resolved
Hide resolved
cugni
approved these changes
Sep 25, 2024
osopardo1
approved these changes
Sep 26, 2024
JosepSampe
added a commit
that referenced
this pull request
Oct 24, 2024
* Issue #424: Add sampling fraction option for optimization (#426) * Add sampling fraction option for optimization and remove analyze from QbeastTable * Issue #430: Simplify denormalized blocks creation (#431) * Simplify Denormalized Blocks * Issue #416: Add CDFQuantile Transformers and Transformations (#413) * Issue 264: Update qviz for multiblock files (#437) * Update Qbeast Visualiser (qviz) with multiblock files --------- Co-authored-by: Jorge Marín <jorge.marin.rodenas@estudiantat.upc.edu> Co-authored-by: Jorge Marín <100561030+jorgeMarin1@users.noreply.github.com> * Issue #441: Fix dataChange flag in optimize (#444) * Merge from main branch --------- Co-authored-by: jiawei <47899566+Jiaweihu08@users.noreply.github.com> Co-authored-by: Paola Pardo <paolapardoat@gmail.com> Co-authored-by: Jorge Marín <jorge.marin.rodenas@estudiantat.upc.edu> Co-authored-by: Jorge Marín <100561030+jorgeMarin1@users.noreply.github.com>
JosepSampe
pushed a commit
to JosepSampe/qbeast-spark
that referenced
this pull request
Oct 24, 2024
…beast-io#426) * Add sampling fraction option for optimization and remove analyze from QbeastTable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424
It changes the optimization API from
optimize(revisionID: RevisionID, options: Map[String, String])tooptimize(revisionID: RevisionID, fraction: Double, options: Map[String, String])When a valid fraction is provided, it finds all
IndexFilesfrom the specified revision that contains anyBlockb thatb.minWeight.fraction <= fraction.Type of change
Checklist:
Here is the list of things you should do before submitting this pull request: