Fix GiveKeys when vehicle is spawned by admin menu. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafewtm
reviewed
Sep 29, 2024
mafewtm
reviewed
Sep 29, 2024
server/main.lua
Outdated
| local plate = qbx.getVehiclePlate(NetworkGetEntityFromNetworkId(netId)) | ||
|
|
||
| exports.qbx_vehiclekeys:GiveKeys(source, plate) | ||
| exports.qbx_vehiclekeys:GiveKeys(source, NetworkGetEntityFromNetworkId(netId)) |
There was a problem hiding this comment.
This is unneeded, I believe, as the spawnVehicle function returns both the entity and the netId if I remember correctly.
There was a problem hiding this comment.
Thank you. I'm reviewing the code, a lot of it is still using old functions, I'm readapting it here. I just saw that a function is called to add a key to the client, but it wasn't working for some reason, the admin script itself is using a lot of functions internally (qb-*).
There was a problem hiding this comment.
What he is referring to is that at line 292 that function returns both the netid and the entity number so you just need to take it from that function and pass it directly to the export.
solareon
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix GiveKeys when vehicle is spawned by admin menu, change wrong parameter plate to vehicle entity.
Checklist