Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seeing/hearing other players in multichar #248

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: seeing/hearing other players in multichar #248

merged 2 commits into from
Nov 15, 2023

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Nov 15, 2023

Description

Hopefully fixes seeing/hearing other players in multichar as stated in #226

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

client/character.lua Outdated Show resolved Hide resolved
client/character.lua Outdated Show resolved Hide resolved
@FjamZoo
Copy link
Contributor

FjamZoo commented Nov 15, 2023

BTW this should probably have proper testing due to the fact we use OAL which normally needs every single parameter inside of natives filled out to work properly, and it looks like: https://docs.fivem.net/natives/?_0xBBDF066252829606

Has a 3rd parameter, which could cause issues making this "not work"

@BerkieBb
Copy link
Contributor

BTW this should probably have proper testing due to the fact we use OAL which normally needs every single parameter inside of natives filled out to work properly, and it looks like: https://docs.fivem.net/natives/?_0xBBDF066252829606

Has a 3rd parameter, which could cause issues making this "not work"

That's actually not OAL that requires it, just the vscode extension. OAL only requires you to not use vector unpacking. You can leave last arguments empty because they always have a default value, usually it's false

@FjamZoo
Copy link
Contributor

FjamZoo commented Nov 15, 2023

BTW this should probably have proper testing due to the fact we use OAL which normally needs every single parameter inside of natives filled out to work properly, and it looks like: https://docs.fivem.net/natives/?_0xBBDF066252829606
Has a 3rd parameter, which could cause issues making this "not work"

That's actually not OAL that requires it, just the vscode extension. OAL only requires you to not use vector unpacking. You can leave last arguments empty because they always have a default value, usually it's false

Sounds good i will merge then

@FjamZoo FjamZoo merged commit 00db6b0 into Qbox-project:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants