Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/player): only set state when possible #440

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

solareon
Copy link
Contributor

Description

Trying to set a statebag when the player is offline probably ain't gonna work. This moves these set events into a conditional that should correct issues with offline player data management

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon
Copy link
Contributor Author

Fixes Qbox-project/qbx_management#56

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about setMetadata?

Also could move the var creation into the if source statement

@solareon
Copy link
Contributor Author

What about setMetadata?

Also could move the var creation into the if source statement

good catch. Was looking for the localized state and missed this one

@solareon solareon merged commit 66b90c7 into main Apr 14, 2024
4 checks passed
@mafewtm mafewtm deleted the statebag-patch-1 branch April 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants