Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): everything else #531

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat(types): everything else #531

merged 1 commit into from
Aug 13, 2024

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Aug 11, 2024

Description

Finishes adding the rest of the types for qbx_core. I intentionally left out the config and module annotations as I figured those should stay where they are. If we think otherwise, I can move those as well.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

solareon
solareon approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make my editor happy?

@mafewtm mafewtm requested a review from Manason August 12, 2024 14:28
@mafewtm mafewtm merged commit fa7731a into main Aug 13, 2024
4 checks passed
@mafewtm mafewtm deleted the types branch August 13, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

@solareon solareon solareon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafewtm @solareon @Manason