Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/functions): ban checking when no license2 #533

Merged
merged 6 commits into from
Aug 13, 2024
Merged

fix(server/functions): ban checking when no license2 #533

merged 6 commits into from
Aug 13, 2024

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Aug 12, 2024 •
edited
Loading

Description

Fixes an issue introduced in #519 where function catches when checking for a player without license2

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

solareon
solareon approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dealer's choice

server/functions.lua Outdated Show resolved Hide resolved
@solareon solareon mentioned this pull request Aug 12, 2024
Closed
2 tasks
@mafewtm mafewtm requested review from solareon and Manason August 12, 2024 14:28
mmoftah
mmoftah reviewed Aug 12, 2024
View reviewed changes
server/functions.lua Outdated Show resolved Hide resolved
@mmoftah
Copy link

mmoftah commented Aug 12, 2024

LGTM, tested locally and it lets me in 🎉

Manason
Manason approved these changes Aug 13, 2024
View reviewed changes
server/functions.lua Show resolved Hide resolved
@mafewtm mafewtm merged commit e3a5579 into main Aug 13, 2024
4 checks passed
@mafewtm mafewtm deleted the no-license2 branch August 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoftah mmoftah mmoftah left review comments

@solareon solareon solareon approved these changes

@Manason Manason Manason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mafewtm @mmoftah @solareon @Manason