Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/config): adjust to match ox_lib #607

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Oct 24, 2024

Description

With the new default timeout being increased to 30 seconds in ox_lib, our core config option should reflect that.

I'm also of the opinion that it can now be removed but that's up to yall.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree that it can (and should) be removed.

@D4isDAVID D4isDAVID merged commit bf226dc into main Oct 24, 2024
4 checks passed
@D4isDAVID D4isDAVID deleted the adjust-timeout branch October 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants