Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evnsq Client::IsReady() implement wrong #21

Closed
zieckey opened this issue Apr 6, 2017 · 0 comments
Closed

evnsq Client::IsReady() implement wrong #21

zieckey opened this issue Apr 6, 2017 · 0 comments

Comments

@zieckey
Copy link
Collaborator

zieckey commented Apr 6, 2017

We must iterate every NSQConn in conns_ to check whether it is OK.

bool Client::IsReady() const {
    if (conns_.empty()) {
        return false;
    }

    return conns_[0]->IsReady();
}

And in Client::OnConnection, when the NSQConn is at 'kConnected' status, should't we move it to conns_??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant