Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain QPY support in install#release-schedule #1563

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jun 17, 2024

Qiskit contract with respect of QPY is kind of strong and deserves an explanation. Adding it to https://docs.quantum.ibm.com/start/install#release-schedule

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

docs/start/install.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 363 to 366
<details>
<summary id="qpy-support">
QPY support
</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this up to be adjacent to the upgrade strategy section before the pre and post-release sections. Realistically my old repeated complaint is that we need more hierarchy to the headings in this section of the docs is really showing here, because this will look pretty awkward on the rendered docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javabster @Eric-Arellano what do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving it next to upgrade strategy makes sense to me. Also we will soon begin working on this issue to move some of the more open-source focused information into a dedicated section, instead of trying to squeeze it all into the install page, so hopefully this should help ease the header hierarchy issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we should merge this as suggested in this PR and move it with #605 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means we can move it next to the upgrade strategy for this PR. I just mentioned #605 in response to matthews comment about not liking the header hierarchy in general

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and squashed. Thanks!

Comment on lines 369 to 371
to load QPY files generated with a newer version of Qiskit using an older release. To facilitate user migration across major version releases, the `qiskit.qpy.dump()` function will always support at least one overlapping version between the `X.0.0` and the `X-1.Y.0` release (where `Y` is the last minor version of
that series). This will enable saving QPY format files that can be loaded by both major versions from the newer
release. See more details in [RFC 0020](https://github.com/Qiskit/RFCs/blob/master/0020-release_cycle.md#qpy-support).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing missing here is I think a link to the qpy dump() docs and also maybe calling out the version kwarg because that's the mechanism to support doing this. I might prefer linking to the qpy docs instead of the rfc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link included in 8291ba9

version is mentioned in fb822da

docs/start/install.mdx Outdated Show resolved Hide resolved
@javabster javabster added this pull request to the merge queue Jul 8, 2024
Merged via the queue into Qiskit:main with commit 3642d67 Jul 8, 2024
1 check passed
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Qiskit contract with respect of QPY is kind of strong and deserves an
explanation. Adding it to
https://docs.quantum.ibm.com/start/install#release-schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants