Suppress warnings from Qiskit Nature #230

SaashaJoshi · 2023-06-01T15:58:13Z

Resolves #154

coveralls · 2023-06-01T15:59:49Z

Pull Request Test Coverage Report for Build 5146937856

8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 89.375%

Totals
Change from base Build 5127839616:	0.008%
Covered Lines:	2330
Relevant Lines:	2607

💛 - Coveralls

garrison · 2023-06-01T16:04:01Z

circuit_knitting_toolbox/entanglement_forging/cholesky_decomposition.py

+from qiskit_nature import settings
+
+settings.use_pauli_sum_op = False
+


Since it may violate a user's expectations to modify global state like this, it deserves some comments here of why it's necessary and also deserves mention in the release notes. (At least it is a temporary thing, and will have no effect on Qiskit Nature versions 0.7 and higher.)

Also, it might be better to move this one level up, to entanglement_forging/__init__.py, for increased visibility.

garrison · 2023-06-06T16:48:26Z

When I run this branch under pytest, all versions pass:

  py38: OK (105.50=setup[71.32]+cmd[34.19] seconds)
  py39: OK (129.52=setup[89.50]+cmd[40.02] seconds)
  py310: OK (138.50=setup[100.98]+cmd[37.52] seconds)
  py311: OK (135.71=setup[102.40]+cmd[33.30] seconds)
  congratulations :) (509.33 seconds)

When I run the tests again locally against current development versions, using python tools/extremal_dependency_versions.py pin_dependencies dev --inplace (this is destructive; it modifies pyproject.toml), then all tests pass again as well:

  py38: OK (878.60=setup[865.89]+cmd[12.71] seconds)
  py39: OK (161.98=setup[147.90]+cmd[14.08] seconds)
  py310: OK (152.29=setup[140.42]+cmd[11.88] seconds)
  py311: OK (152.60=setup[142.16]+cmd[10.44] seconds)
  congratulations :) (1345.72 seconds)

When I run notebooks from this branch, they fail on all versions of python:

  py38-notebook: FAIL code 1 (181.68=setup[73.70]+cmd[107.98] seconds)
  py39-notebook: FAIL code 1 (184.47=setup[74.37]+cmd[110.11] seconds)
  py310-notebook: FAIL code 1 (189.66=setup[75.84]+cmd[113.82] seconds)
  py311-notebook: FAIL code 1 (173.32=setup[75.39]+cmd[97.94] seconds)
  evaluation failed :( (729.22 seconds)

So, at the moment, it seems that the tests fail only on the notebook(s), regardless of python version.

garrison · 2023-06-06T17:01:27Z

I thought for a moment that fixing this might be as simple as importing the entanglement_forging module before using Qiskit Nature to do anything, but I tried this and it doesn't seem to have fixed anything.

garrison · 2023-06-06T21:00:50Z

circuit_knitting_toolbox/entanglement_forging/__init__.py

+from qiskit_nature import settings
+
+settings.use_pauli_sum_op = False
+


These lines actually need to be moved to circuit_knitting/forging/__init__.py now that #244 is merged.

And it'd be great if you could add a comment above it:

From now forward, the entanglement forging module requires that SparsePauliOp be used rather than PauliSumOp, as the latter is deprecated in Qiskit Terra 0.24. However, Qiskit Nature still is not expected to change this default until Qiskit Nature 0.7. Here, we modify the global state to opt into the new behavior early. Unfortunately, this means that any code that calls Qiskit Nature in the same process as entanglement forging will need to be updated to use SparsePauliOp as well.

Also, once we finally figure out the magic to get everything working, we should double check that this block is actually required to get tests to pass. The migration guide suggests that it is not always necessary to change this setting. If you provide a SparsePauliOp to a function that returns an operator, it should result in a SparsePauliOp regardless of this setting, from what I understand.

Yes, this was in fact added after a discussion between @caleb-johnson and Max (Rossmannek). He suggested that we can suppress the warnings with these settings until opflow is dropped, which will be in the 0.8.0 release.

garrison · 2023-06-07T14:48:29Z

The following line in pyproject.toml is preventing Qiskit Nature 0.6.0 from being used in the notebook tests, but I believe that using SparsePauliOp (this PR) requires getting rid of that upper bound. (At least, there is no attribute setting.use_pauli_sum_op in earlier versions.) That might then cause a failure related to quantum serverless in one of the notebooks, but we can evaluate what to do about that (this is all related to #108).

https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/4a0cd45c5f28b196800aefd843f380ba7136494c/pyproject.toml#L84

The dependency should also be updated at the following line in order for the minimum version tests to pass:

https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/4a0cd45c5f28b196800aefd843f380ba7136494c/pyproject.toml#L31

The README badge should be updated to match that version, too.

pyproject.toml

garrison

This looks great. Let's wait for @caleb-johnson's approval, too.

fwiw, I tried to remove settings.use_pauli_sum_op = False, but tests failed, so it looks like we have to keep it. Not a big surprise, but I wanted to double check that it is absolutely necessary.

garrison · 2023-06-16T23:22:54Z

Oh yes -- I forgot before approving: This certainly deserves a release note, too.

caleb-johnson

This looks great, thanks @SaashaJoshi and @garrison !

I suggested a couple of small simplifications on the import and like Jim suggested, please add a release note covering this change. :)

circuit_knitting/forging/cholesky_decomposition.py

circuit_knitting/forging/entanglement_forging_ground_state_solver.py

caleb-johnson · 2023-06-16T23:56:32Z

docs/entanglement_forging/tutorials/tutorial_2_forging_with_quantum_serverless.ipynb

@@ -11,7 +11,7 @@
    "\n",
    "See [Tutorial 1](tutorial_1_getting_started.ipynb) for a high-level breakdown of the entanglement forging algorithm, or check out the [explanatory material](../explanation/index.rst) for a more detailed explanation.\n",
    "\n",
-    "<span style=\"color:red\"><i>Quantum Serverless does not support Qiskit Nature 0.6.0 yet. In order to use entanglement forging with quantum serverless, users should use 0.5.2 < Qiskit Nature < 0.6.0. There is an [associated issue in the quantum-serverless repo](https://github.com/Qiskit-Extensions/quantum-serverless/issues/413) to address this.</i></span>"
+    "<span style=\"color:red\"><i>Quantum Serverless does not support Qiskit Nature 0.6.0 yet. In order to use entanglement forging with quantum serverless, users should downgrade to version 0.2 of the Circuit Knitting Toolbox, as it is compatible with Qiskit Nature 0.5.2. There is an [associated issue in the quantum-serverless repo](https://github.com/Qiskit-Extensions/quantum-serverless/issues/413) to address this.</i></span>"


Co-authored-by: Caleb Johnson <calebj1524@outlook.com>

…ver.py Co-authored-by: Caleb Johnson <calebj1524@outlook.com>

garrison

Awesome, thanks!

caleb-johnson · 2023-06-19T15:55:49Z

releasenotes/notes/remove-opflow-177bb07ba0e68002.yaml

@@ -0,0 +1,8 @@
+---


caleb-johnson

Looks great, thanks!

SaashaJoshi added 2 commits May 31, 2023 19:31

Change PauliSumOp to SparsePauliOp; Remove QubitConverter()

b3554f4

suppress warnings from qiskit-nature

eefd725

minor style check changes

f3c0d6a

garrison reviewed Jun 1, 2023

View reviewed changes

change location of pauliSumOp setting

70f7e40

SaashaJoshi added 4 commits June 6, 2023 13:44

minor changes to docstrings

ed0521c

avoiding merge conflicts

b83c49c

Merge remote-tracking branch 'origin/main' into pauliSumOp

1ed13bb

import settings to avoid using pauliSumOp

244712e

garrison reviewed Jun 6, 2023

View reviewed changes

SaashaJoshi added 4 commits June 7, 2023 13:07

add comment

7c2c1bc

minor change

c83b88d

remove upper bound on qiskit-nature version for notebooks

b61f3d5

change qiskit-nature version dependencies

71cc4e6

garrison mentioned this pull request Jun 16, 2023

Add Forging/Serverless tutorial back on development CI workflow when serialization of ElectronicStructureProblem is addressed #108

Closed

5 tasks

garrison reviewed Jun 16, 2023

View reviewed changes

pyproject.toml Show resolved Hide resolved

update README.md and quantum-serverless tutorial

4845f54

garrison linked an issue Jun 16, 2023 that may be closed by this pull request

Replace ListOp in EntForging #161

Closed

garrison previously approved these changes Jun 16, 2023

View reviewed changes

garrison added this to the 0.3.0 milestone Jun 16, 2023

garrison added the forging label Jun 16, 2023

caleb-johnson reviewed Jun 16, 2023

View reviewed changes

SaashaJoshi dismissed garrison’s stale review via 1566a9b June 17, 2023 00:16

SaashaJoshi and others added 2 commits June 16, 2023 20:16

Update circuit_knitting/forging/cholesky_decomposition.py

1566a9b

Co-authored-by: Caleb Johnson <calebj1524@outlook.com>

Update circuit_knitting/forging/entanglement_forging_ground_state_sol…

d418f13

…ver.py Co-authored-by: Caleb Johnson <calebj1524@outlook.com>

garrison mentioned this pull request Jun 19, 2023

Move configuration out of extremal-python-dependencies #269

Merged

SaashaJoshi and others added 2 commits June 19, 2023 11:18

Merge branch 'Qiskit-Extensions:main' into pauliSumOp

b8047f4

add release note

27279a7

garrison approved these changes Jun 19, 2023

View reviewed changes

caleb-johnson reviewed Jun 19, 2023

View reviewed changes

releasenotes/notes/remove-opflow-177bb07ba0e68002.yaml

@@ -0,0 +1,8 @@

---

Copy link

Collaborator

caleb-johnson Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

caleb-johnson approved these changes Jun 19, 2023

View reviewed changes

SaashaJoshi merged commit 8f40d0a into Qiskit:main Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suppress warnings from Qiskit Nature #230

Suppress warnings from Qiskit Nature #230

SaashaJoshi commented Jun 1, 2023 •

edited by caleb-johnson

Loading

coveralls commented Jun 1, 2023 •

edited

Loading

garrison Jun 1, 2023

garrison Jun 1, 2023

garrison commented Jun 6, 2023 •

edited

Loading

garrison commented Jun 6, 2023

garrison Jun 6, 2023

garrison Jun 6, 2023

garrison Jun 6, 2023

SaashaJoshi Jun 6, 2023

garrison commented Jun 7, 2023

garrison left a comment

garrison commented Jun 16, 2023

caleb-johnson left a comment

caleb-johnson Jun 16, 2023

garrison left a comment

caleb-johnson Jun 19, 2023

caleb-johnson left a comment

		from qiskit_nature import settings

		settings.use_pauli_sum_op = False

Suppress warnings from Qiskit Nature #230

Suppress warnings from Qiskit Nature #230

Conversation

SaashaJoshi commented Jun 1, 2023 • edited by caleb-johnson Loading

coveralls commented Jun 1, 2023 • edited Loading

Pull Request Test Coverage Report for Build 5146937856

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garrison commented Jun 6, 2023 • edited Loading

garrison commented Jun 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garrison commented Jun 7, 2023

garrison left a comment

Choose a reason for hiding this comment

garrison commented Jun 16, 2023

caleb-johnson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garrison left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caleb-johnson left a comment

Choose a reason for hiding this comment

SaashaJoshi commented Jun 1, 2023 •

edited by caleb-johnson

Loading

coveralls commented Jun 1, 2023 •

edited

Loading

garrison commented Jun 6, 2023 •

edited

Loading