Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pylint's unused-argument check #419

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

garrison
Copy link
Member

Closes #319.

I changed CutQC's _print_cutter_result to display num_cuts as well (previously, it ignored it). In passing, I also removed the num_subcircuit argument to this function, as it was redundant with len(subcircuits).

In other files, I prefixed intentionally ignored arguments with unused_ or ignored_ so pylint will ignore them.

@garrison garrison added the code quality Related to style, linters, etc. label Sep 14, 2023
@garrison
Copy link
Member Author

garrison commented Sep 14, 2023

Heh, there remains one more unused argument: num_threads at https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/cutqc/tutorials/tutorial_3_cutting_with_quantum_serverless.html. I went ahead and removed it -- seemed like the most obvious way to handle this.

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@garrison garrison merged commit e58f786 into main Oct 4, 2023
@garrison garrison deleted the unused-argument-check branch October 4, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to style, linters, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't find unused function args
2 participants