Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qiskit Runtime retry loop #58

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Remove Qiskit Runtime retry loop #58

merged 2 commits into from
Jun 2, 2023

Conversation

garrison
Copy link
Member

This removes the retry loop which would handle when Qiskit Runtime would return a result of None. The bug that caused this issue has been fixed in the service, so the retry loop is no longer necessary.

I'm in no hurry to merge this, but I wanted to open a PR nonetheless before we forget about it.

This removes the retry loop which would handle when Qiskit Runtime
would return a result of `None`.  The bug that caused this issue
has been fixed in the service, so the retry loop is no longer
necessary.
@coveralls
Copy link

coveralls commented Nov 11, 2022

Pull Request Test Coverage Report for Build 3442073556

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 85.028%

Files with Coverage Reduction New Missed Lines %
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_knitter.py 4 84.38%
Totals Coverage Status
Change from base Build 3432365720: 0.3%
Covered Lines: 1522
Relevant Lines: 1790

💛 - Coveralls

@garrison garrison added the on hold Let's wait for something before merging label Nov 14, 2022
@caleb-johnson
Copy link
Collaborator

I support this whenever you think it's ready. I believe this call should be much more stable now

@garrison garrison removed the on hold Let's wait for something before merging label Jun 1, 2023
@garrison garrison added this to the 0.3.0 milestone Jun 1, 2023
@garrison garrison requested a review from caleb-johnson June 2, 2023 01:21
@garrison garrison merged commit 618e133 into main Jun 2, 2023
@garrison garrison deleted the rm-runtime-retry-loop branch June 2, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants