Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit dependency on ipykernel #595

Merged
merged 2 commits into from
May 22, 2024
Merged

Remove explicit dependency on ipykernel #595

merged 2 commits into from
May 22, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented May 21, 2024 •
edited
Loading

This is no longer necessary now that a release has been made which includes jupyter/jupyter-sphinx#226.

This PR reverts #345.

@garrison
Remove explicit dependency on ipykernel
7e9492c 
This is no longer necessary now that a release has been made
which includes jupyter/jupyter-sphinx#226.
@garrison garrison added the dependencies Pull requests that update a dependency file label May 21, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9183975241

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.528%
Totals Coverage Status
Change from base Build 9183970128: 0.0%
Covered Lines: 3546
Relevant Lines: 3712
💛 - Coveralls

@garrison garrison marked this pull request as ready for review May 22, 2024 02:11
@garrison garrison merged commit 2afe393 into main May 22, 2024
11 checks passed
@garrison garrison deleted the garrison-patch-1 branch May 22, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrison @coveralls