Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize API docs #22

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

Applies the same changes from Qiskit/qiskit-addon-obp#24. Refer to that for more explanation.

Some notes:

  • Removes qiskit_addon_mpf.rst, since users don't actually import this module directly
  • Inlines the three functions and one class in qiskit_addon_mpf.static. This means that it is our only API file, since there is only one module!
    • I'm not 100% sure it makes sense to inline these interfaces. Feel free to push back. They all seemed small enough to be worth it, but you can disagree.

@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11558528080

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11494511689: 0.0%
Covered Lines: 53
Relevant Lines: 53

💛 - Coveralls

@Eric-Arellano Eric-Arellano added the stable backport potential Label for mergify to open a backport PR label Oct 25, 2024
@Eric-Arellano Eric-Arellano merged commit 0667163 into Qiskit:main Oct 30, 2024
15 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/reorg-docs branch October 30, 2024 15:12
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
Applies the same changes from Qiskit/qiskit-addon-obp#24. Refer to that for more explanation.

Some notes:

* Removes `qiskit_addon_mpf.rst`, since users don't actually import this module directly
* Inlines the three functions and one class in `qiskit_addon_mpf.static`. This means that it is our only API file, since there is only one module!
    - I'm not 100% sure it makes sense to inline these interfaces. Feel free to push back. They all seemed small enough to be worth it, but you can disagree.

(cherry picked from commit 0667163)
Eric-Arellano added a commit that referenced this pull request Oct 30, 2024
Applies the same changes from Qiskit/qiskit-addon-obp#24. Refer to that for more explanation.

Some notes:

* Removes `qiskit_addon_mpf.rst`, since users don't actually import this module directly
* Inlines the three functions and one class in `qiskit_addon_mpf.static`. This means that it is our only API file, since there is only one module!
    - I'm not 100% sure it makes sense to inline these interfaces. Feel free to push back. They all seemed small enough to be worth it, but you can disagree.

(cherry picked from commit 0667163)

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential Label for mergify to open a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants