Scrub old Cython-related code and comments #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aer has not used Cython at all since late 2020 (see Qiskit#1014), and there were still a few minor comment references to it in the code. This also removes two CMake files that were used during the Cython build process, but are no longer needed, except for a trivial variable that was only used in `FindPybind11.cmake`, and is now calculated there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Aer has not used Cython at all since late 2020 (see #1014), and there
were still a few minor comment references to it in the code. This also
removes two CMake files that were used during the Cython build process,
but are no longer needed, except for a trivial variable that was only
used in
FindPybind11.cmake, and is now calculated there.Details and comments
This is just bookkeeping - mostly just deleting old CMake files we're not using. At the time of making this commit, it looks like all the rest of the files in
/cmakeare used in build processes in some form. It was on my mind because Qiskit/qiskit#1439 scrubs some public references to Cython, and I was interested enough to have a check through the old history to see how Aer used to use it.