Deprecate approximation option in Estimator #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikkoham
changed the title
ikkoham
added
the
Changelog: Deprecation
doichanj
approved these changes
Oct 24, 2023
woodsp-ibm
reviewed
Oct 24, 2023
| warn( | ||
| "Option approximation=False is deprecated as of qiskit-aer 0.13. " | ||
| "It will be removed no earlier than 3 months after the release date. " | ||
| "Instead, use BackendEstmator from qiskit.primitives.", |
There was a problem hiding this comment.
I just happened to notice this PR - in looking over it I see that BackendEstimator is missing the i in this warning - same in the one below. Pretty minor but I thought I'd point it out.
doichanj
pushed a commit
to doichanj/qiskit-aer
that referenced
this pull request
Oct 26, 2023
* Deprecate approximation * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate approximation option.
approximation=Truewill be the default in the future.If users want to use
approximation=False, they should useBackendEstimatorinstead.Details and comments