Bug fix: ISA check inside control flow operations whose body is defined in a separate circuit #1954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1916 fixed a bug related to connectivity inside control operations. @jakelishman has pointed out a case where the fix does not apply correctly. The case is exemplified in the test
test_isa_inside_condition_block_body_in_separate_circuit
, which is added in the current PR. Running the test, either on Shrebrooke or Cusco, results withThe current PR fixes the error, and makes the test pass.
The fix is copied from qiskit's
GatesInBasis
pass, from a previous version where the pass was still written in Python.