Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate circuit_indices and observable_indices and add circuits and observables #331

Merged
merged 18 commits into from
Jun 2, 2022
Merged

Deprecate circuit_indices and observable_indices and add circuits and observables #331

merged 18 commits into from
Jun 2, 2022

Conversation

rathishcholarajan
Copy link
Member

@rathishcholarajan rathishcholarajan commented May 19, 2022 •
edited
Loading

Summary

Deprecate circuit_indices and observable_indices and add circuits and observables.
circuits and observables can take actual circuits and observables as well as indices.

Details and comments

Fixes #315

TODO:

@rathishcholarajan rathishcholarajan self-assigned this May 19, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@rathishcholarajan rathishcholarajan mentioned this pull request May 19, 2022
Merged
1 task
@coveralls
Copy link

coveralls commented May 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2429957947

  • 31 of 116 (26.72%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 66.274%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qiskit/primitives/utils.py 6 7 85.71%
qiskit_ibm_runtime/qiskit/primitives/base_sampler.py 10 39 25.64%
qiskit_ibm_runtime/qiskit/primitives/base_estimator.py 11 66 16.67%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qiskit/primitives/base_estimator.py 1 27.84%
qiskit_ibm_runtime/qiskit/primitives/base_sampler.py 1 36.23%
Totals Coverage Status
Change from base Build 2429207328: -1.2%
Covered Lines: 2647
Relevant Lines: 3994
💛 - Coveralls

@rathishcholarajan rathishcholarajan marked this pull request as ready for review May 26, 2022 19:00
blakejohnson
blakejohnson requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@blakejohnson blakejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a correctness perspective. We should update the tutorials to include examples that pass the objects and not just indices.

@rathishcholarajan
Copy link
Member Author

This looks good from a correctness perspective. We should update the tutorials to include examples that pass the objects and not just indices.

👍 Updated in 837368e

@rathishcholarajan rathishcholarajan merged commit de446f4 into Qiskit:main Jun 2, 2022
@rathishcholarajan rathishcholarajan deleted the 315-deprecate-indices branch June 2, 2022 21:50
@rathishcholarajan rathishcholarajan added the Changelog: API Change Include in the Changed section of the changelog label Jun 17, 2022
@rathishcholarajan rathishcholarajan added this to the 0.5.0 milestone Jun 20, 2022
@jyu00 jyu00 mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakejohnson blakejohnson blakejohnson approved these changes

@ajavadia ajavadia Awaiting requested review from ajavadia

@levbishop levbishop Awaiting requested review from levbishop

@ikkoham ikkoham Awaiting requested review from ikkoham

@t-imamichi t-imamichi Awaiting requested review from t-imamichi

Assignees

@rathishcholarajan rathishcholarajan

Labels
Changelog: API Change Include in the Changed section of the changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Deprecate circuit_indices and observable_indices and replace with circuits and observables
3 participants
@rathishcholarajan @coveralls @blakejohnson