-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warning for unsupported parameters of transpilation settings #866
Conversation
…-ibm-runtime into remove_deprecations
Pull Request Test Coverage Report for Build 5104060843
💛 - Coveralls |
Since it's been more than 6 months, I think we can just ignore unsupported options |
…ion_method'. Added a general check instead
…-ibm-runtime into remove_deprecations
When checking the removal of deprecation warning, I noticed that if an unsupported option is passed, the server will return an error (possibly after a long time). So I added validation checks for level 2 options. We already have checks for level 1 and level 3. |
We specifically allow kwargs in |
@jyu00 - Indeed there is an environment variable that controls whether to run _validate_options or not. So the user can turn set |
Summary
Removed 1 deprecation warning for unsupported parameters of
transpilation settings
.Details and comments
Part of #784 .
Question - regarding
translation_method
andtiming_constraints
, do we want to raise an error or simply ignore? Because for other unsupported options, we simply ignore.