Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning for unsupported parameters of transpilation settings #866

Merged
merged 24 commits into from
Aug 10, 2023

Conversation

merav-aharoni
Copy link
Contributor

@merav-aharoni merav-aharoni commented May 22, 2023

Summary

Removed 1 deprecation warning for unsupported parameters of transpilation settings.

Details and comments

Part of #784 .
Question - regarding translation_method and timing_constraints, do we want to raise an error or simply ignore? Because for other unsupported options, we simply ignore.

@merav-aharoni merav-aharoni changed the title Remove deprecation warning from over 3 months Remove deprecation warning for unsupported parameters of transpilation settings May 23, 2023
@coveralls
Copy link

coveralls commented May 23, 2023

Pull Request Test Coverage Report for Build 5104060843

  • 24 of 24 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.73%

Totals Coverage Status
Change from base Build 5082986167: 0.2%
Covered Lines: 2587
Relevant Lines: 3557

💛 - Coveralls

@merav-aharoni merav-aharoni marked this pull request as ready for review May 23, 2023 10:53
@merav-aharoni merav-aharoni requested a review from kt474 May 23, 2023 10:53
@kt474
Copy link
Member

kt474 commented May 23, 2023

Question - regarding translation_method and timing_constraints, do we want to raise an error or simply ignore? Because for other unsupported options, we simply ignore.

Since it's been more than 6 months, I think we can just ignore unsupported options

@merav-aharoni
Copy link
Contributor Author

When checking the removal of deprecation warning, I noticed that if an unsupported option is passed, the server will return an error (possibly after a long time). So I added validation checks for level 2 options. We already have checks for level 1 and level 3.

@kt474 kt474 added this to the 0.10.1 milestone May 30, 2023
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label May 30, 2023
@jyu00
Copy link
Collaborator

jyu00 commented May 30, 2023

We specifically allow kwargs in Options to let people test undocumented features. That's why these dataclasses are decorated with @_flexible. If you are going to raise, perhaps one can bypass the validation with an env variable (I think there was one before, but maybe it's in qiskit-ibm-provider).

@merav-aharoni
Copy link
Contributor Author

@jyu00 - Indeed there is an environment variable that controls whether to run _validate_options or not. So the user can turn set QISKIT_RUNTIME_SKIP_OPTIONS_VALIDATION=False to turn off all the validations.

@kt474 kt474 removed this from the 0.10.1 milestone Jun 12, 2023
@kt474 kt474 merged commit 9e600ad into Qiskit:main Aug 10, 2023
@merav-aharoni merav-aharoni deleted the remove_deprecations branch August 13, 2023 07:29
@kt474 kt474 added this to the 0.12.0 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants