Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support updating job tags #950

Merged
merged 7 commits into from
Jul 16, 2023
Merged

Support updating job tags #950

merged 7 commits into from
Jul 16, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jul 13, 2023

Summary

Details and comments

Fixes #944

@coveralls
Copy link

coveralls commented Jul 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5568731620

  • 4 of 13 (30.77%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.016%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/clients/runtime.py 2 3 66.67%
qiskit_ibm_runtime/runtime_job.py 2 10 20.0%
Totals Coverage Status
Change from base Build 5557896679: -0.2%
Covered Lines: 2427
Relevant Lines: 3279
💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review July 13, 2023 20:00
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Jul 13, 2023
@kt474 kt474 requested a review from merav-aharoni July 14, 2023 14:16
merav-aharoni
merav-aharoni approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just please address @atharva-satpute 's comment.

@kt474 kt474 merged commit a898f09 into Qiskit:main Jul 16, 2023
@kt474 kt474 deleted the update-tags branch July 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atharva-satpute atharva-satpute atharva-satpute left review comments

@merav-aharoni merav-aharoni merav-aharoni approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the possibility to update tags of a RuntimeJob
4 participants
@kt474 @coveralls @merav-aharoni @atharva-satpute