Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circuit & observable indicies #971

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Remove circuit & observable indicies #971

merged 5 commits into from
Aug 3, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jul 25, 2023

Summary

Details and comments

Fixes #970

@kt474 kt474 added the Changelog: Removal Include in the Removed section of the changelog label Jul 25, 2023
@coveralls
Copy link

coveralls commented Jul 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5730853188

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.086%
Totals Coverage Status
Change from base Build 5721636912: 0.0%
Covered Lines: 2433
Relevant Lines: 3284
💛 - Coveralls

@kt474 kt474 requested a review from mberna July 25, 2023 04:27
@kt474 kt474 requested a review from merav-aharoni August 1, 2023 19:12
merav-aharoni
merav-aharoni approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have no comments.

@kt474 kt474 merged commit d5c2c4a into Qiskit:main Aug 3, 2023
@kt474 kt474 deleted the remove-data-caching-code branch August 3, 2023 16:03
@kt474 kt474 mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merav-aharoni merav-aharoni merav-aharoni approved these changes

@mberna mberna Awaiting requested review from mberna

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove circuit_indices and observable_indices
3 participants
@kt474 @coveralls @merav-aharoni