This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Support updating program data #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow updating program data * fix lint * fix lint again * Apply suggestions from code review Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
rathishcholarajan
added
the
Changelog: API Change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the owner to update runtime program data without having to delete it first.
Details and comments
The program update endpoint expects the program data to be in plain text, even though the upload endpoint expects it to be in binary (I think the latter will be changed soon). As a result, the input data to update_program is of type string. This makes the upload_program quite confusing, since it treated data of type string as the program file path. To make the 2 match, this PR changes the signature of upload_program to only take data in string format, and inspect it to see if it's program data or file path.
Backported from Qiskit/qiskit-ibm-provider#141