This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Remove invalid type hint from least_busy method #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes an invalid type hint from the least_busy method. This method was incorrectly listing the BaseBackend class as a valid input and output type from the method. This has not been a supported type since Qiskit#817. Additionally, the class has been deprecated in qiskit-terra for ~1 year now and was recently removed from the main development branch. The ibmq provider should not be importing using this legacy type, especially for a type hint as it is not used anywhere.
mtreinish
added
Changelog: Bugfix
rathishcholarajan
approved these changes
Apr 20, 2022
Merged
rathishcholarajan
pushed a commit
that referenced
this pull request
Apr 20, 2022
This commit removes an invalid type hint from the least_busy method. This method was incorrectly listing the BaseBackend class as a valid input and output type from the method. This has not been a supported type since #817. Additionally, the class has been deprecated in qiskit-terra for ~1 year now and was recently removed from the main development branch. The ibmq provider should not be importing using this legacy type, especially for a type hint as it is not used anywhere.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes an invalid type hint from the least_busy method.
This method was incorrectly listing the BaseBackend class as a valid
input and output type from the method. This has not been a supported
type since #817. Additionally, the class has been deprecated in
qiskit-terra for ~1 year now and was recently removed from the main
development branch. The ibmq provider should not be importing using
this legacy type, especially for a type hint as it is not used
anywhere.
Details and comments