This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
disable, save, and stored account #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-plan9
reviewed
Jun 28, 2019
diego-plan9
approved these changes
Jun 28, 2019
Rcuz8
pushed a commit
to Rcuz8/qiskit-ibmq-provider
that referenced
this pull request
Jun 14, 2022
* Fix websocket connection drop (Qiskit#1090) (Qiskit#212) * Fix websocket connection drop (Qiskit#1090) * Fix websocket connection drop Reset retry counter after every successful connection, ping ws server every minute so connection doesn't drop every few mins * No longer need to wait for running state before streaming results * Sending ping to ws server every minute is enough No need to reset retry count to 0 since there are some error scenarios where we shouldn't keep trying forever * Update releasenotes/notes/fix-websocket-connection-drop-3892e313554e99df.yaml * Move release notes to 0.18 archive
Rcuz8
pushed a commit
to Rcuz8/qiskit-ibmq-provider
that referenced
this pull request
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses #193.
Details and comments
Since the signature for
save_accountremains the same as IBMQProvider, I think we should take v1 token and issue a warning, similar to what we do withenable_account.