Update Sphinx theme #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Sep 29, 2023
docs/conf.py
Outdated
| @@ -42,6 +42,7 @@ | |||
| 'reno.sphinxext', | |||
| 'sphinx.ext.intersphinx', | |||
| "sphinxcontrib.jquery", # Remove when changing html_theme to qiskit_ecosystem. | |||
| 'qiskit_sphinx_theme' | |||
There was a problem hiding this comment.
Suggested change
| 'qiskit_sphinx_theme' | |
| 'qiskit_sphinx_theme', |
docs/conf.py
Outdated
| @@ -42,6 +42,7 @@ | |||
| 'reno.sphinxext', | |||
| 'sphinx.ext.intersphinx', | |||
| "sphinxcontrib.jquery", # Remove when changing html_theme to qiskit_ecosystem. | |||
mtreinish
approved these changes
Sep 29, 2023
|
This LGTM, but CI is failing because of a dependency conflict on the sphinx version: https://github.com/Qiskit/qiskit-neko/actions/runs/6354846073/job/17264430483?pr=32#step:7:108 I think once that is sorted and you mark this as ready for review we should be good to merge this. |
|
@mtreinish Thank you! Yes, the conflict is with the Sphinx version, and that version needs at leat python 3.8 as well. I will update the version of Python in another pull request to work with python 3.8 - 3.11. |
mtreinish
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates to new Ecosystem theme.
For more information: Qiskit/qiskit_sphinx_theme#232