Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for physical qubits #2

Merged
merged 71 commits into from
Apr 28, 2023
Merged

Add support for physical qubits #2

merged 71 commits into from
Apr 28, 2023

Commits on Jan 27, 2023

  1. Add support for physical qubits

    @jlapeyre
    jlapeyre committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5643ee8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Remove unneeded check for param equal to None in ValueResolver.visit

    @jlapeyre
    jlapeyre committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    25cc6a6 View commit details
    Browse the repository at this point in the history

  2. Split tests into separate functions

    @jlapeyre
    jlapeyre committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    6e45b50 View commit details
    Browse the repository at this point in the history

  3. Remove exploratory method

    @jlapeyre
    jlapeyre committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    7d1e005 View commit details
    Browse the repository at this point in the history

  4. Remove commented out cruft in OQ code

    @jlapeyre
    jlapeyre committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    194a822 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Move AddressingMode

    @jlapeyre
    jlapeyre committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    1be5b9d View commit details
    Browse the repository at this point in the history

  2. Add HardwareQubit

    @jlapeyre
    jlapeyre committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0a1661d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Simplify generating layout at end of conversion

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8843730 View commit details
    Browse the repository at this point in the history

  2. Find and fix wrong calls to resolve_condition

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ff68731 View commit details
    Browse the repository at this point in the history

  3. Store all relevant state in ValueResolver

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    86a1407 View commit details
    Browse the repository at this point in the history

  4. Remove cruft

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    94488d7 View commit details
    Browse the repository at this point in the history

  5. Fix linter errors

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    988a793 View commit details
    Browse the repository at this point in the history

  6. Reject HW qubit in gate body 

    * Also test generated layout when in hw qubit addressing mode.
    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2ffe778 View commit details
    Browse the repository at this point in the history

  7. Add tests for HW qubits in nested scopes

    @jlapeyre
    jlapeyre committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2c614a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Test that hardware qubits are incorrectly treated local in local scope 

    This needs to be fixed. For now, we include a test that requires the
broken behavior.
    @jlapeyre
    jlapeyre committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    73bc35f View commit details
    Browse the repository at this point in the history

  2. Update a test for code changes

    @jlapeyre
    jlapeyre committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    31cd1ce View commit details
    Browse the repository at this point in the history

  3. Fix small review items 

    * Remove commented out unused code
* Disable too-many-lines globally
* auto-Document HardwareQubits
* Use Enum in AddressingMode
    @jlapeyre
    jlapeyre committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    8f18ca9 View commit details
    Browse the repository at this point in the history

  4. Remove quotes from "State" and import State into file

    @jlapeyre
    jlapeyre committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    55f1a90 View commit details
    Browse the repository at this point in the history

  5. Move State from converter.py to state.py

    @jlapeyre
    jlapeyre committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    8e9524b View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Fix lint errors

    @jlapeyre
    jlapeyre committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    053b2bc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Add clarifying inline comment

    @jlapeyre
    jlapeyre committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    43a6234 View commit details
    Browse the repository at this point in the history

  2. Implement class SymbolTable 

    Use SymbolTable class with an API rather than just using a simple dict
    @jlapeyre
    jlapeyre committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    92de1b5 View commit details
    Browse the repository at this point in the history

  3. Fix search order for symbols 

    tests_convert.py now works.
But things before API change are hardcoded in other tests.
    @jlapeyre
    jlapeyre committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8b3c72a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Fix bugs and lint complaints

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b35b7f8 View commit details
    Browse the repository at this point in the history

  2. Add doc strings, comments, and small adjustments to SymbolTable API

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    81d6260 View commit details
    Browse the repository at this point in the history

  3. Test that gate params shadow global symbol

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c8b86e3 View commit details
    Browse the repository at this point in the history

  4. Add test that parameter may shadow builtin symbol

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    20ce76a View commit details
    Browse the repository at this point in the history

  5. Add test that input variable may shadow builtin symbol 

    * Add some doc strings
* Clean up API in a class
    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ab9d6ca View commit details
    Browse the repository at this point in the history

  6. Remove obsolete comment

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c880c43 View commit details
    Browse the repository at this point in the history

  7. Improve doc strings in SymbolTable

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    86215b5 View commit details
    Browse the repository at this point in the history

  8. Small DRY improvement

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8bd67a0 View commit details
    Browse the repository at this point in the history

  9. Make ConverVisitor.convert return the state containing the circuit 

    Previously, it returned just the circuit. This does not change the public
API. But it allows the developer to examine the state after convesion.
    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    9987ac1 View commit details
    Browse the repository at this point in the history

  10. Update docstring to reflect change in class structure

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    e878653 View commit details
    Browse the repository at this point in the history

  11. Fix docstring so that sphinx build succeeds

    @jlapeyre
    jlapeyre committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    41f27fe View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Update src/qiskit_qasm3_import/converter.py 

    Co-authored-by: Jake Lishman <jake@binhbar.com>
    @jlapeyre @jakelishman
    jlapeyre and jakelishman committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6e738e0 View commit details
    Browse the repository at this point in the history

  2. Modify SymbolTable.insert to accept only single symbols, not lists

    @jlapeyre
    jlapeyre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c76006c View commit details
    Browse the repository at this point in the history

  3. Update doc string for previous commit

    @jlapeyre
    jlapeyre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e869c11 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Reflow lines to 100 characters

    @jlapeyre
    jlapeyre committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f86ee07 View commit details
    Browse the repository at this point in the history

  2. Rename _type to type

    @jlapeyre
    jlapeyre committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ef0b676 View commit details
    Browse the repository at this point in the history

  3. reformat with black 

    revert attempt at wrapping doc string without wrapping the displayed string.
    @jlapeyre
    jlapeyre committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    380fbfc View commit details
    Browse the repository at this point in the history

  4. Include unused argument rather than disabling arguments-differ

    @jlapeyre
    jlapeyre committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9810016 View commit details
    Browse the repository at this point in the history

  5. Remove use of walrus operator

    @jlapeyre
    jlapeyre committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9203545 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Test Enum with is rather than ==

    @jlapeyre
    jlapeyre committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0748035 View commit details
    Browse the repository at this point in the history

  2. Remove test involving invalid identifier $q

    @jlapeyre
    jlapeyre committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    94fb45f View commit details
    Browse the repository at this point in the history

  3. Test hardware qubit use after introduction in a previous local scope

    @jlapeyre
    jlapeyre committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    855dc13 View commit details
    Browse the repository at this point in the history

  4. Test detect mixed addressing mode if HW qubit first referenced in loc… 

    …al scope
    @jlapeyre
    jlapeyre committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    efa1e03 View commit details
    Browse the repository at this point in the history

  5. Test that user defined gate can be defined and used in HW mode

    @jlapeyre
    jlapeyre committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c918b9f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Simplify nested conditionals in handling identifiers

    @jlapeyre
    jlapeyre committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    7606c70 View commit details
    Browse the repository at this point in the history

  2. Replace == with is in another comparison of Enum

    @jlapeyre
    jlapeyre committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    1d8b5f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Implement stack-like SymbolTable

    @jlapeyre
    jlapeyre committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7d2e926 View commit details
    Browse the repository at this point in the history

  2. Fix broken layout for physical qubits

    @jlapeyre
    jlapeyre committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    cc568fc View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Move _STDGATES where it belongs

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    bf80706 View commit details
    Browse the repository at this point in the history

  2. Move hardware_qubit_map to converter.py

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    9199a6a View commit details
    Browse the repository at this point in the history

  3. Change parens to make logic in conditional easier to read

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e894ba1 View commit details
    Browse the repository at this point in the history

  4. Remove useless check for missing global symbol table

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1cd0d3a View commit details
    Browse the repository at this point in the history

  5. Change identifer init_inner to _init_inner

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    33ee260 View commit details
    Browse the repository at this point in the history

  6. Fix incorrect init of State in test_conditions.py

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    68c6541 View commit details
    Browse the repository at this point in the history

  7. Remove asserts used in debugging

    @jlapeyre
    jlapeyre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4a19f39 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Prepend underscores to private variable names

    @jlapeyre
    jlapeyre committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8b5da10 View commit details
    Browse the repository at this point in the history

  2. Add some documentation

    @jlapeyre
    jlapeyre committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    00e6415 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Add tests for behavior of SymbolTable and start fixing

    @jlapeyre
    jlapeyre committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    7a412ea View commit details
    Browse the repository at this point in the history

  2. Run black, and add test file to repo

    @jlapeyre
    jlapeyre committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8e02af4 View commit details
    Browse the repository at this point in the history

  3. Add missing file for real this time

    @jlapeyre
    jlapeyre committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    abafec5 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Add more informative __repr__ for two classes

    @jlapeyre
    jlapeyre committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    13d39f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Implement SymbolTables 

    Use a stack instead of a recursive structure for managing nested symbol tables.
    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    11c718b View commit details
    Browse the repository at this point in the history

  2. Add a couple of comments

    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cecc387 View commit details
    Browse the repository at this point in the history

  3. Run black

    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a6b9789 View commit details
    Browse the repository at this point in the history

  4. Refactor class State

    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8fd058d View commit details
    Browse the repository at this point in the history

  5. Remove PhysicalQubitInGateError and refactor _check_visible

    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    24d7bda View commit details
    Browse the repository at this point in the history

  6. Improve error message

    @jlapeyre
    jlapeyre committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    9288bc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Improve performance of AddressingMode 

    This change increases performance by a factor of 1.5 or 2.
Setting when already set takes about 65ns vs 120ns.
Probably not a bottleneck at the moment.
    @jlapeyre
    jlapeyre committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e7ac664 View commit details
    Browse the repository at this point in the history