Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lock files #1154

Closed
wants to merge 9 commits into from
Closed

Create lock files #1154

wants to merge 9 commits into from

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jan 4, 2024

Summary

Fix #1153

This PR creates a lock file for:

  • ray-node
  • notebook
  • gateway
  • repository

This way we reduce build times that were starting to be problematic until we close a more definitive version. This dependencies are being ignored also through renovate.

Dockerfile-ray-node Outdated Show resolved Hide resolved
@psschwei
Copy link
Collaborator

psschwei commented Jan 5, 2024

For python 3.8, getting this error: Could not find a version that satisfies the requirement ipython==8.18.1

@psschwei
Copy link
Collaborator

psschwei commented Jan 5, 2024

Maybe we need to unpin that one?

@Tansito
Copy link
Member Author

Tansito commented Jan 5, 2024

My two cents @psschwei , could be that how I created this requirements-lock with python 3.10 the libraries are not compatible with python 3.8? That would mean that we will need to have a lock per python version, right?

@Tansito
Copy link
Member Author

Tansito commented Jan 5, 2024

Btw, yes, 8.18.1 is not compatible: #1118

@psschwei
Copy link
Collaborator

psschwei commented Jan 5, 2024

That makes sense... I pulled the versions from the 3.9 image... let's pin to 8.13.0 (?)

@Tansito
Copy link
Member Author

Tansito commented Jan 5, 2024

Closing this in favour of #1155

@Tansito Tansito closed this Jan 5, 2024
@Tansito Tansito deleted the pin-versions branch January 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build is taking too much due to dependency resolver
2 participants