Filter by access in the program list for catalog client #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
changed the title
gateway/tests/fixtures/fixtures.json
Outdated
| @@ -79,7 +79,10 @@ | |||
| "image": "icr.io/awesome-namespace/awesome-title", | |||
| "author": 2, | |||
| "env_vars": "{\"PROGRAM_ENV1\": \"VALUE1\", \"PROGRAM_ENV2\": \"VALUE2\"}", | |||
| "provider": "bfe8aa6a-2127-4123-bf57-5b547293cbea" | |||
| "provider": "bfe8aa6a-2127-4123-bf57-5b547293cbea", | |||
There was a problem hiding this comment.
Would you add another api.program that has only 100 instead of adding 100 here so that it can make sure this instance is not returned?
akihikokuroda
requested changes
Oct 23, 2024
|
Redhat is returning a 504 downloading the image, I will wait an retry the action later @akihikokuroda |
|
@akihikokuroda it should be everything fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until now we were returning in the catalog all those functions that had view access. With this PR the filter will only return those functions with view access by the user.