Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement error message in job #1528

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Conversation

korgan00
Copy link
Collaborator

Summary

If job.status() is ERROR, return raw result in error_message() and raise an exception in result()
else return an empty string in error_message() and return raw result in result()

Details and comments

Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Tansito
Copy link
Member

Tansito commented Oct 29, 2024

@pandasa123 we should update documentation with this right, where should we take a look?

@korgan00 korgan00 merged commit f96e432 into main Oct 30, 2024
10 checks passed
@Tansito Tansito deleted the add-error-message-in-job-result branch November 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants