Add is_running_in_serverless() function
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @garrison , I will contact with @pandasa123 to review the naming but this can be very useful definitely! |
|
This looks great. I think the name makes sense |
Tansito
reviewed
Oct 31, 2024
There was a problem hiding this comment.
@garrison after talking with @pandasa123 in our weekly could we change the name of the method to something more near to what is doing the project right now?
My proposal: is_running_in_serverless()
Suggested at #1532 (review)
I like this even better. Equally clear, less verbose (and fewer underscores). Updated accordingly in 4ed7f8f. |
garrison
changed the title
is_running_as_serverless_program() functionis_running_in_serverless() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a function so that the user can easily detect whether the program is running under Qiskit serverless. In some instances, a person may want to be able to branch on whether that is the case.
Details and comments
I am not necessarily attached to this name.
For the tests, I improved them by making the environment variable handling be temporary and in a fixture. This meant a slight migration to pytest style (from unittest style), and silencing a pylint warning.