Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place dunder methods added #10252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArushSamadhia
Copy link

Summary

Follow up from issue #9555
Made changes in the file quantumcircuitdata.py

Details and comments

@ArushSamadhia ArushSamadhia requested a review from a team as a code owner June 10, 2023 16:53
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 10, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@Raghav-Bell
Copy link
Contributor

Raghav-Bell commented Aug 8, 2023

Replace self.circuit.data with self._circuit.data as QuantumCircuitData does not have circuit as an attribute. Also add some tests and release note. (See contribution guide)

@Raghav-Bell
Copy link
Contributor

It fixes #9555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants