Force decimal points in OpenQASM 2 floats #10532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
The letter of the OpenQASM 2 specification has a regex defining floating-point literals that requires a decimal point, even in the presence of an exponential component. This is unusual for most programming languages, but Qiskit's exporter should follow the spec as close as we can to increase interop. Our parser accepts floats with an exponent and no decimal point as a minor syntax extension, unless in strict mode.
jakelishman
force-pushed
the
qasm2/force-decimal-point
branch
from
318feab to
24a0217
Compare
Pull Request Test Coverage Report for Build 5716223165
💛 - Coveralls |
kevinhartman
approved these changes
Jul 31, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* Force decimal points in OpenQASM 2 floats The letter of the OpenQASM 2 specification has a regex defining floating-point literals that requires a decimal point, even in the presence of an exponential component. This is unusual for most programming languages, but Qiskit's exporter should follow the spec as close as we can to increase interop. Our parser accepts floats with an exponent and no decimal point as a minor syntax extension, unless in strict mode. * Simplify English (cherry picked from commit 4722c50)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* Force decimal points in OpenQASM 2 floats The letter of the OpenQASM 2 specification has a regex defining floating-point literals that requires a decimal point, even in the presence of an exponential component. This is unusual for most programming languages, but Qiskit's exporter should follow the spec as close as we can to increase interop. Our parser accepts floats with an exponent and no decimal point as a minor syntax extension, unless in strict mode. * Simplify English (cherry picked from commit 4722c50) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The letter of the OpenQASM 2 specification has a regex defining floating-point literals that requires a decimal point, even in the presence of an exponential component. This is unusual for most programming languages, but Qiskit's exporter should follow the spec as close as we can to increase interop. Our parser accepts floats with an exponent and no decimal point as a minor syntax extension, unless in strict mode.
Details and comments
Fix #10531.