-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BasePrimitiveJob
class and deprecate PrimitiveJob.submit
method
#11552
Conversation
One or more of the the following people are requested to review this:
|
13692df
to
9913f32
Compare
Pull Request Test Coverage Report for Build 7537622138Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
I think the other Essentially
|
Since |
9913f32
to
531c35d
Compare
531c35d
to
9d5482a
Compare
I copied all |
I left some relatively minor comments. Other than those, this LGTM. Also, I should clarify that I'm not strongly against keeping |
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
I agree with your idea to deprecate |
Summary
Add
BasePrimitiveJob
class and deprecatePrimitiveJob.submit
methodResolves #11541
TODO
Details and comments