Deprecate accidentally public internal helper methods on QuantumCircuit #12785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
ElePT
added
the
Changelog: Deprecation
Pull Request Test Coverage Report for Build 10073672823Details
💛 - Coveralls |
ElePT
added
the
mod: circuit
ElePT
force-pushed
the
deprecate-accidents
branch
from
58ae8ea
to
aa4a429
Compare
Cryoris
reviewed
Jul 24, 2024
qiskit/circuit/quantumcircuit.py
Outdated
| @classmethod | ||
| @deprecate_func( | ||
| since=1.2, | ||
| removal_timeline="in qiskit 2.0", |
There was a problem hiding this comment.
Should we uppercase this? 🙂
Suggested change
| removal_timeline="in qiskit 2.0", | |
| removal_timeline="in Qiskit 2.0", |
There was a problem hiding this comment.
I wrote it in lowercase because the beginning of the message writes qiskit in lowercase. But I also don't love it. Anyways, I modified the timeline message in a7b7361 to say
"in the 2.0 release" to be consistent with other deprecations (qobj and assemble).
There was a problem hiding this comment.
Oh I didn't notice... that seems odd. Maybe we should change that as well 🤔 (not here ofc)
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
reviewed
Jul 24, 2024
Cryoris
approved these changes
Jul 24, 2024
ElePT
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jul 24, 2024
…it (Qiskit#12785) * Deprecate accidentally public qc helper methods * Fix lint * Complete reno and add removal timeline * Update qiskit/circuit/quantumcircuit.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update remaining docstrings and removal timeline. * Trailing whitespace --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…it (Qiskit#12785) * Deprecate accidentally public qc helper methods * Fix lint * Complete reno and add removal timeline * Update qiskit/circuit/quantumcircuit.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update remaining docstrings and removal timeline. * Trailing whitespace --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12417. I added the "private version" of the methods so that we can then remove the public one in 2.0. Let me know if you had a different idea for the deprecation.
Details and comments