Allow overriding Rust toolchain in tox runs
#12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be convenient to use different versions of the Rust toolchain for various `tox` runs. This can already be done externally to `tox` by a stateful `rustup override set <x>` followed by clearing the override after the tox run, but allowing the environment variable to pass through lets it be localised to just a single run.
jakelishman
added
type: qa
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10114481476Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
approved these changes
Jul 26, 2024
mtreinish
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
It can be convenient to use different versions of the Rust toolchain for various `tox` runs. This can already be done externally to `tox` by a stateful `rustup override set <x>` followed by clearing the override after the tox run, but allowing the environment variable to pass through lets it be localised to just a single run. (cherry picked from commit b362df0)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
It can be convenient to use different versions of the Rust toolchain for various `tox` runs. This can already be done externally to `tox` by a stateful `rustup override set <x>` followed by clearing the override after the tox run, but allowing the environment variable to pass through lets it be localised to just a single run. (cherry picked from commit b362df0) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
It can be convenient to use different versions of the Rust toolchain for various `tox` runs. This can already be done externally to `tox` by a stateful `rustup override set <x>` followed by clearing the override after the tox run, but allowing the environment variable to pass through lets it be localised to just a single run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It can be convenient to use different versions of the Rust toolchain for various
toxruns. This can already be done externally totoxby a statefulrustup override set <x>followed by clearing the override after the tox run, but allowing the environment variable to pass through lets it be localised to just a single run.Details and comments