-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate qiskit.result.mitigation
#13351
Conversation
Pull Request Test Coverage Report for Build 11595253287Details
💛 - Coveralls |
qiskit.result.deprecation
qiskit.result.mitigation
One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I had one question inline about the release note. But it's easy enough to fix in the release notes roundup as we approach the final release. Feel free to enqueue this for merge.
The ``qiskit.result.mitigation`` module has been deprecated and will be removed in the 2.0 release. | ||
The deprecation includes the ``LocalReadoutMitigator`` and ``CorrelatedReadoutMitigator`` classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't want to use class
refs for these? They seem to be in the docs: https://docs.quantum.ibm.com/api/qiskit/qiskit.result.LocalReadoutMitigator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remember if we would use refs for removals, I will keep it in mind and suggest the changes in the reno copy-editing phase. This way we can get the merge queue going with this PR :)
removal_timeline="in Qiskit 2.0", | ||
additional_msg="The `qiskit.result.mitigation` module is deprecated in favor of " | ||
"the https://github.com/Qiskit/qiskit-addon-mthree package.", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only the 3 classes above are actually public so these technically could just be removed. But it's good to deprecate them anyway and remove it all at once.
Summary
Closes #12838
Details and comments