Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Github Actions #13474

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Conversation

raynelfss
Copy link
Contributor

@raynelfss raynelfss commented Nov 21, 2024

Summary

Fixes #12807.
The following commits move existing workflows from Azure into Github Actions.

Details and comments

As simple as it may seem, our CI Pipeline goes through several workflows, some of which are split between Github Actions and Azure Workflows. While Azure Workflows provided us with many extra features and an isolated quota, tests seem to run much slower than they would with Github Actions (exact numbers to be examined). This move will (most likely) ensure that workflows run faster increasing our overall commit throughput.

The moved workflows include:

  • Pull Requests:
    • Docs and Lint
    • Python and partial rust tests.
  • Commits:
    • On push
    • Nightly tests
    • Merge queue

New Pull Request workflow

The new PR workflow looks as such:
image
Where if both Docs and Lint and Preliminary Tests pass, then the rest of the test suite runs concurrently.

Tasks

  • Move Lint and Docs
  • Move Python Tests
  • Organize concurrency
  • Add nightly tests
  • Merge queue tests
  • Run nightly matrix tests when code changes.

Known issues

  • How to properly test merge-queue, push, nightly tests.
  • Main nightly tests should only run when new changes in the code are introduced (as per the previous azure workflow).

@raynelfss raynelfss added the type: qa Issues and PRs that relate to testing and code quality label Nov 21, 2024
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12263408990

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.924%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 91.23%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 12261510589: -0.03%
Covered Lines: 79366
Relevant Lines: 89251

💛 - Coveralls

@raynelfss raynelfss force-pushed the move-to-gh branch 2 times, most recently from 74a0fe4 to ba1a164 Compare November 25, 2024 13:46
@raynelfss raynelfss force-pushed the move-to-gh branch 2 times, most recently from ebc3e6e to e0c9a46 Compare December 2, 2024 18:51
@raynelfss raynelfss added the Changelog: None Do not include in changelog label Dec 3, 2024
- Add comments
- Rename `Qiskit CI workflow` to `Pull Request`
- Add missing `.yml` extension in reusable workflow references.
@raynelfss
Copy link
Contributor Author

I have yet to test the nightly, merge-queue, and push tests. But I believe they should work without issues since they're mostly reusing the same workflows we use here for Pull Requests CI. I'm going to open this up for review :)

@raynelfss raynelfss marked this pull request as ready for review December 3, 2024 19:57
@raynelfss raynelfss requested a review from a team as a code owner December 3, 2024 19:57
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to github actions
3 participants