-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to Github Actions #13474
Open
raynelfss
wants to merge
22
commits into
Qiskit:main
Choose a base branch
from
raynelfss:move-to-gh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate CI to Github Actions #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynelfss
added
the
type: qa
Issues and PRs that relate to testing and code quality
label
Nov 21, 2024
raynelfss
force-pushed
the
move-to-gh
branch
from
November 21, 2024 21:17
19bce30
to
fb398bb
Compare
Pull Request Test Coverage Report for Build 12263408990Details
💛 - Coveralls |
raynelfss
force-pushed
the
move-to-gh
branch
2 times, most recently
from
November 25, 2024 13:46
74a0fe4
to
ba1a164
Compare
raynelfss
force-pushed
the
move-to-gh
branch
2 times, most recently
from
December 2, 2024 18:51
ebc3e6e
to
e0c9a46
Compare
- Added `depth: 0` to checkout to avoid reno bugs.
- Rename `tests-linux.yml` to `test-linux.yml`.
- Add comments - Rename `Qiskit CI workflow` to `Pull Request`
- Add missing `.yml` extension in reusable workflow references.
I have yet to test the nightly, merge-queue, and push tests. But I believe they should work without issues since they're mostly reusing the same workflows we use here for Pull Requests CI. I'm going to open this up for review :) |
One or more of the following people are relevant to this code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: None
Do not include in changelog
type: qa
Issues and PRs that relate to testing and code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12807.
The following commits move existing workflows from Azure into Github Actions.
Details and comments
As simple as it may seem, our CI Pipeline goes through several workflows, some of which are split between Github Actions and Azure Workflows. While Azure Workflows provided us with many extra features and an isolated quota, tests seem to run much slower than they would with Github Actions (exact numbers to be examined). This move will (most likely) ensure that workflows run faster increasing our overall commit throughput.
The moved workflows include:
New Pull Request workflow
The new PR workflow looks as such:
Where if both
Docs and Lint
andPreliminary Tests
pass, then the rest of the test suite runs concurrently.Tasks
Known issues