Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces V1 Primitives in README.md with V2 Primitives. #13487

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Replaces V1 Primitives in README.md with V2 Primitives. #13487

merged 1 commit into from
Nov 25, 2024

Conversation

t-imamichi
Copy link
Member

Summary

This PR replaces V1 Primitives in README.md with V2 Primitives.

Fixes #12824 (comment)

Details and comments

@t-imamichi t-imamichi added the documentation Something is not clear or an error documentation label Nov 25, 2024
@t-imamichi t-imamichi requested a review from a team as a code owner November 25, 2024 10:12
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@t-imamichi t-imamichi added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12007797203

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.004%) to 88.94%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 92.13%
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 91.98%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 11977726745: 0.004%
Covered Lines: 79407
Relevant Lines: 89282
💛 - Coveralls

ElePT
ElePT approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added the Changelog: None Do not include in changelog label Nov 25, 2024
@ElePT ElePT added this pull request to the merge queue Nov 25, 2024
Merged via the queue into Qiskit:main with commit 4c1de13 Nov 25, 2024
19 of 20 checks passed
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@t-imamichi @mergify
update readme (#13487)
2564187 
(cherry picked from commit 4c1de13)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
@t-imamichi t-imamichi deleted the readme-primitives branch November 26, 2024 01:22
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
@mergify @t-imamichi
update readme (#13487) (#13491)
3a1ee15 
(cherry picked from commit 4c1de13)

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-imamichi @qiskit-bot @coveralls @ElePT