Fix registering global_phase parameters when creating CircuitData
#13538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
Cryoris
commented
Dec 6, 2024
| @@ -1528,16 +1539,18 @@ impl CircuitData { | |||
| /// * capacity - The capacity for instructions to use in the output `CircuitData` | |||
| /// If `None` the length of `other` will be used, if `Some` the integer | |||
| /// value will be used as the capacity. | |||
| pub fn clone_empty_like(other: &Self, capacity: Option<usize>) -> Self { | |||
| CircuitData { | |||
| pub fn clone_empty_like(py: Python, other: &Self, capacity: Option<usize>) -> PyResult<Self> { | |||
There was a problem hiding this comment.
This change is necessary since CircuitData::set_global_phase requires the Python token. This function is so far only ever used in pauli_twirl_2q_gates, so it is a very non-intrusive change.
Pull Request Test Coverage Report for Build 12200862552Details
💛 - Coveralls |
Cryoris
added
the
stable backport potential
eliarbel
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a series of bugs caused by not correctly registering the parameters in the
CircuitDatas parameter table upon creation. This led to theQuantumCircuit.global_phaseattribute not being assigned upon callingassign_parameters. Fixes #13534.Details and comments
I checked for all constructors that take in a
global_phaseand tried to add tests for each (e.g.pauli_twirl_2q_gatesinvokesclone_empty_like).