-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more 1q and 2q Pauli rotation equivalences #7407
Conversation
seems there are still some issues with tests.. I'll look into this |
Thanks for the PR @tyrolize! Could you also add the following translations, incl. tests:
|
I'll have a look at this this week! |
@tyrolize, are you still working on this? 🙂 |
yep, will try to look at this this week, sorry for the delays :) |
Co-authored-by: Julien Gacon <gaconju@gmail.com>
…a more logical variant
@Cryoris I can't figure out what causes tests to fail. |
Hi @tyrolize it seems like the test case You can check in the contributing guidelines how to run the tests locally 😄 |
Pull Request Test Coverage Report for Build 5323764887
💛 - Coveralls |
ping @Cryoris ? |
This needs a reno but then LGTM. |
Summary
Fixes #7332
Details and comments
I noticed that in some equivalence relations the theta parameter is defined only for the first equivalence relation (see RZGate in the changed file). I wonder if this is the best practice.