Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializable parametric pulse #7821
Serializable parametric pulse #7821
Changes from 18 commits
afe4f96
9a8a582
6f2496a
0424636
1bf11fa
2335f32
2af235d
0cc7383
a59af77
21ef762
509470a
ed2f661
c4b41d5
71ef841
cf7f302
c2981d0
cf17341
ba685ef
f2ef950
2ea6390
f48796e
0738497
92f42eb
1440a23
4345c3b
1c63ddb
d121b0d
48ff3cc
b9cab67
42b3dd9
761235d
cc12bf8
6c21edd
43e0e0b
6b956de
eefa5e4
252f62b
f24e648
4d191be
2c8e7f8
3a0f506
d5517d5
be2ed0c
67ac61f
78288ac
cbada64
ecb4ea7
45ae755
a4a56db
d957458
6776743
d4e8c43
41bf4f5
2aa4f5a
2e521a7
09855d7
b99eb5c
ac23d6f
401c1f4
686e77b
84344c2
914018e
045d67b
3b2c571
8edaba9
9b0adc3
cda7336
ef35cd9
15e9f7c
d844253
526aaed
87d3538
be2b4e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will slotting this class have any upgrade implications. I don't think so because it's an abc and all the subclasses will have
__dict__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a slots for efficiency of instance generation. As experiment scales with larger processor, we need to create tons of pulse instance internally. Perhaps my code is doing something wrong in this context?