Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DAGNode deprecations #7902

Merged
merged 16 commits into from
May 3, 2022
Merged

Conversation

enavarro51
Copy link
Contributor

Summary

Removes DAGNode deprecations

Details and comments

Since 0.20.0 has been released and the 3 months have passed, this PR removes the deprecations to DAGNode that were added as part of #6567.

@enavarro51 enavarro51 requested a review from a team as a code owner April 6, 2022 18:48
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 2261384756

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 84.349%

Files with Coverage Reduction New Missed Lines %
qiskit/dagcircuit/dagnode.py 1 89.39%
Totals Coverage Status
Change from base Build 2261332291: 0.02%
Covered Lines: 54463
Relevant Lines: 64569

💛 - Coveralls

Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enavarro51 , this looks good to me. Can you add a "removal" release note?

@enavarro51
Copy link
Contributor Author

Actually as I looked at this, should we be leaving the name getter and setter? I thought we were going to still allow node.name. Thanks.

@enavarro51
Copy link
Contributor Author

@kdk Ok. Release note done and I put the name setter and getter back.

@enavarro51
Copy link
Contributor Author

@kdk. NVM. Just realized name getter and setter were now in DAGOpNode. Should be all good now.

kdk
kdk previously approved these changes May 2, 2022
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enavarro51 , this looks good to me!

@kdk kdk added Changelog: Removal Include in the Removed section of the changelog automerge labels May 2, 2022
@kdk kdk added this to the 0.21 milestone May 2, 2022
@jakelishman
Copy link
Member

There was a seemingly bad-luck test failure on this on Windows/Python3.7, so I've restarted that, and it should go through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants