-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DAGNode deprecations #7902
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2261384756
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enavarro51 , it looks like there's a section in the tutorial https://github.com/Qiskit/qiskit-tutorials/blob/721d67ac97e8f0ca3b9b4156cc35a9a777363d12/tutorials/circuits_advanced/04_transpiler_passes_and_passmanager.ipynb that still uses the deprecated node.condition
form and is leading to the failure at https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=35731&view=logs&j=b32a9d47-7bd3-5443-5e7c-fab46a446055&t=186ae8ed-dea6-5bc5-f4e3-12f54632f4a9&l=60 . That would need to be updated before this PR can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enavarro51 , this looks good to me. Can you add a "removal" release note?
Actually as I looked at this, should we be leaving the |
@kdk Ok. Release note done and I put the name setter and getter back. |
@kdk. NVM. Just realized name getter and setter were now in DAGOpNode. Should be all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enavarro51 , this looks good to me!
releasenotes/notes/remove-dagnode-deprecations-30703a2156d52b8a.yaml
Outdated
Show resolved
Hide resolved
There was a seemingly bad-luck test failure on this on Windows/Python3.7, so I've restarted that, and it should go through now. |
Summary
Removes DAGNode deprecations
Details and comments
Since 0.20.0 has been released and the 3 months have passed, this PR removes the deprecations to DAGNode that were added as part of #6567.