-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy errors (providers) #8265
base: main
Are you sure you want to change the base?
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
87f4bc6
to
2eeebe0
Compare
Pull Request Test Coverage Report for Build 5713433333
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7370292470
💛 - Coveralls |
ping @jyu00 |
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
The are ~40 errors left:
All error list
There are some ignores added to decorated property, since it's currently is not supported by mypy.
That's already a bit to much to specify all of the problems. I'll try to list those I identified.
There are some errors in
qiskit/providers/basicaer/basicaertools.py
due to the fact thatGate
subclasses constructors are different from constructor ofGate
.There are also multiple errors in
qiskit/providers/models/backendproperties.py
due to the fact thatqubit_property
can return eithe dictionary or tuple depending on the runtime parameters.There are some more that I'm unsure about fixes, help is appreciated.