Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qubits and clbits args to QuantumCircuit.from_instructions #9089

Merged
merged 3 commits into from
Nov 8, 2022
Merged

add qubits and clbits args to QuantumCircuit.from_instructions #9089

merged 3 commits into from
Nov 8, 2022

Conversation

kevinsung
Copy link
Contributor

Summary

Fixes #9048

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner November 7, 2022 18:20
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

jakelishman
jakelishman reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo aside and default comment aside, this looks good to me, thanks. We don't need a release note because it's an addition to a feature that wasn't released yet.

qiskit/circuit/quantumcircuit.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3413170473

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 84.542%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
Totals Coverage Status
Change from base Build 3393994050: 0.006%
Covered Lines: 62462
Relevant Lines: 73883
💛 - Coveralls

@jakelishman jakelishman added automerge Changelog: None Do not include in changelog labels Nov 8, 2022
@jakelishman jakelishman added this to the 0.23.0 milestone Nov 8, 2022
@mergify mergify bot merged commit fbff44b into Qiskit:main Nov 8, 2022
@kevinsung kevinsung deleted the from-instructions-args branch November 8, 2022 13:36
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
@kevinsung @Cryoris
add qubits and clbits args to QuantumCircuit.from_instructions (Qiski…
92bf926 
…t#9089)

* add qubits and clbits args to QuantumCircuit.from_instructions

* test classical bits too

* handle iterable correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

Add qubits and clbits arguments to QuantumCircuit.from_instructions
4 participants
@kevinsung @qiskit-bot @coveralls @jakelishman