Switch from retworkx to rustworkx package #9162

mtreinish · 2022-11-17T22:11:43Z

Summary

In the retworkx/rustworkx 0.12.0 release the package was renamed from retworkx to rustworkx which was done at the request of the networkx maintainers [1]. While the retworkx name continues to work for backwards compatibility, it is best to move off of the legacy name and start using the new name sooner rather than later. This commit updates all the retworkx usage to the new rustworkx and updates our requirements list to directly depend on rustworkx.

Details and comments

Closes #8340 (obsolete)

[1] https://qiskit.org/documentation/rustworkx/release_notes.html#prelude

In the retworkx/rustworkx 0.12.0 release the package was renamed from retworkx to rustworkx which was done at the request of the networkx maintainers [1]. While the retworkx name continues to work for backwards compatibility, it is best to move off of the legacy name and start using the new name sooner rather than later. This commit updates all the retworkx usage to the new rustworkx and updates our requirements list to directly depend on rustworkx. [1] https://qiskit.org/documentation/rustworkx/release_notes.html#prelude

qiskit-bot · 2022-11-17T22:11:46Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

coveralls · 2022-11-17T22:40:17Z

Pull Request Test Coverage Report for Build 3499678724

32 of 32 (100.0%) changed or added relevant lines in 21 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.583%

Totals
Change from base Build 3499561003:	0.0%
Covered Lines:	62524
Relevant Lines:	73920

💛 - Coveralls

jakelishman

Ivan (@IvanIsCoding) has old PR #8340 that did this too, but that never merged at the time because it was quite a bit before the rename actually happened. I don't know what the two of you want to do about the two PRs.

jakelishman · 2022-11-18T12:56:20Z

qiskit/transpiler/preset_passmanagers/common.py

-            vf2_call_limit = int(5e4)  # Set call limit to ~100ms with retworkx 0.10.2
+            vf2_call_limit = int(5e4)  # Set call limit to ~100ms with rustworkx 0.10.2
        elif optimization_level == 2:
-            vf2_call_limit = int(5e6)  # Set call limit to ~10 sec with retworkx 0.10.2
+            vf2_call_limit = int(5e6)  # Set call limit to ~10 sec with rustworkx 0.10.2
        elif optimization_level == 3:
-            vf2_call_limit = int(3e7)  # Set call limit to ~60 sec with retworkx 0.10.2
+            vf2_call_limit = int(3e7)  # Set call limit to ~60 sec with rustworkx 0.10.2


It hardly matters, but rustworkx 0.10.2 never existed.

Heh, you can tell I just ran sed on the repo. :)

qiskit/utils/optionals.py

releasenotes/notes/rustworkx-not-retworkx-b7c4da600df58701.yaml

Co-authored-by: Jake Lishman <jake@binhbar.com>

mtreinish · 2022-11-18T14:36:18Z

As for this PR vs #8340 I think we probably should just move forward with this one. I had forgotten that @IvanIsCoding had tested this a few months ago, if I had seen that PR I would have just pushed to that branch instead of opening a new PR. But assuming @IvanIsCoding doesn't mind since this version is working and up to date already I think it would better to just merge this and get us migrated to the new name sooner rather than later.

jakelishman

I'm happy to move ahead with merging this. I'll hold off tagging automerge til Ivan's had a chance to respond.

IvanIsCoding · 2022-11-18T17:34:19Z

As for this PR vs #8340 I think we probably should just move forward with this one. I had forgotten that @IvanIsCoding had tested this a few months ago, if I had seen that PR I would have just pushed to that branch instead of opening a new PR. But assuming @IvanIsCoding doesn't mind since this version is working and up to date already I think it would better to just merge this and get us migrated to the new name sooner rather than later.

Let's merge Matthew's PR as it is ready, they are the same diff

* Switch from retworkx to rustworkx package In the retworkx/rustworkx 0.12.0 release the package was renamed from retworkx to rustworkx which was done at the request of the networkx maintainers [1]. While the retworkx name continues to work for backwards compatibility, it is best to move off of the legacy name and start using the new name sooner rather than later. This commit updates all the retworkx usage to the new rustworkx and updates our requirements list to directly depend on rustworkx. [1] https://qiskit.org/documentation/rustworkx/release_notes.html#prelude * Fix release note path * Update releasenotes/notes/rustworkx-not-retworkx-b7c4da600df58701.yaml Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

mtreinish added the Changelog: API Change Include in the "Changed" section of the changelog label Nov 17, 2022

mtreinish added this to the 0.23.0 milestone Nov 17, 2022

mtreinish requested review from a team, nonhermitian, eggerdj, wshanks, ikkoham, manoelmarques and woodsp-ibm as code owners November 17, 2022 22:11

mtreinish added 2 commits November 17, 2022 19:51

Fix release note path

ba49709

Merge branch 'main' into rustworkx-not-retworkx-one-day-I-will-remember

8c709ec

jakelishman reviewed Nov 18, 2022

View reviewed changes

Update releasenotes/notes/rustworkx-not-retworkx-b7c4da600df58701.yaml

6ad1dd6

Co-authored-by: Jake Lishman <jake@binhbar.com>

jakelishman previously approved these changes Nov 18, 2022

View reviewed changes

Merge branch 'main' into rustworkx-not-retworkx-one-day-I-will-remember

6d2bcf5

mtreinish dismissed jakelishman’s stale review via 6d2bcf5 November 18, 2022 17:49

jakelishman approved these changes Nov 18, 2022

View reviewed changes

jakelishman added the automerge label Nov 18, 2022

IvanIsCoding mentioned this pull request Nov 18, 2022

[WIP] Switch from retworkx to rustworkx #8340

Closed

Merge branch 'main' into rustworkx-not-retworkx-one-day-I-will-remember

54a857a

mergify bot merged commit b9def99 into Qiskit:main Nov 18, 2022

mtreinish deleted the rustworkx-not-retworkx-one-day-I-will-remember branch November 18, 2022 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from retworkx to rustworkx package #9162

Switch from retworkx to rustworkx package #9162

mtreinish commented Nov 17, 2022 •

edited by jakelishman

Loading

qiskit-bot commented Nov 17, 2022

coveralls commented Nov 17, 2022 •

edited

Loading

jakelishman left a comment

jakelishman Nov 18, 2022

mtreinish Nov 18, 2022

mtreinish commented Nov 18, 2022

jakelishman left a comment

IvanIsCoding commented Nov 18, 2022

Switch from retworkx to rustworkx package #9162

Switch from retworkx to rustworkx package #9162

Conversation

mtreinish commented Nov 17, 2022 • edited by jakelishman Loading

Summary

Details and comments

qiskit-bot commented Nov 17, 2022

coveralls commented Nov 17, 2022 • edited Loading

Pull Request Test Coverage Report for Build 3499678724

💛 - Coveralls

jakelishman left a comment

Choose a reason for hiding this comment

jakelishman Nov 18, 2022

Choose a reason for hiding this comment

mtreinish Nov 18, 2022

Choose a reason for hiding this comment

mtreinish commented Nov 18, 2022

jakelishman left a comment

Choose a reason for hiding this comment

IvanIsCoding commented Nov 18, 2022

mtreinish commented Nov 17, 2022 •

edited by jakelishman

Loading

coveralls commented Nov 17, 2022 •

edited

Loading