Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of Target argument name #9473

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

nkanazawa1989
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 commented Jan 27, 2023

Summary

The misspelled aquire_alignment appears in the Target constructor and attribute. This will be replaced with the correct spelling acquire_alignment.

Details and comments

@nkanazawa1989 nkanazawa1989 requested review from a team and jyu00 as code owners January 27, 2023 05:21
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jan 27, 2023

Pull Request Test Coverage Report for Build 4106954054

  • 9 of 14 (64.29%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 85.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/backend_compat.py 0 1 0.0%
qiskit/transpiler/target.py 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 93.97%
qiskit/pulse/library/waveform.py 3 91.67%
Totals Coverage Status
Change from base Build 4106750995: -0.04%
Covered Lines: 67061
Relevant Lines: 78670

💛 - Coveralls

@kdk kdk added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge labels Feb 6, 2023
@kdk kdk added this to the 0.24.0 milestone Feb 6, 2023
@jakelishman
Copy link
Member

Updated to pull in the fixes to the docs build from #9477.

@mergify mergify bot merged commit 94dcdf3 into Qiskit:main Feb 6, 2023
@wshanks
Copy link
Contributor

wshanks commented Feb 8, 2023

Closes #8422

pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-ibm-provider that referenced this pull request Oct 4, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Oct 10, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Oct 12, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Dec 8, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@nkanazawa1989 nkanazawa1989 deleted the fix/target_argtypo branch December 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants