-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clifford.from_matrix #9475
Merged
Merged
Add Clifford.from_matrix #9475
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37bce39
Add Clifford.from_matrix
itoko 6019306
Add tests
itoko dba2eff
Add reno
itoko bad10de
Faster Clifford.from_matrix O(16^n)->O(4^n)
itoko 7a0c373
Add infinite recursion test case
itoko b64d969
Change to try append with definition first
itoko c4bc00a
Add u gate handling for speed
itoko 8ee86cd
Improve implematation following review comments
itoko bbc1535
Add Clifford.from_operator
itoko 577f306
Merge remote-tracking branch 'upstream/main' into add-clifford-from-m…
itoko 96af80b
Update reno
itoko c34d9ca
Lint
itoko bf028fc
more accurate reno
itoko a4d0b75
Merge branch 'main' into add-clifford-from-matrix
ikkoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add u gate handling for speed
- Loading branch information
commit c4bc00a4c8c78ea468b3715d900c25bf4176b41d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
if not isinstance(param, ParameterExpression)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to try cast here because that checks if a ParameterExpression is bounded or not (not checking the type of
param
).