-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an equiv method to the StabilizerState class #9543
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4126554322
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the maths off the top of my head, but assuming that's correct, the rest of this looks fairly straightforwards. I only had minor comments.
releasenotes/notes/add-equiv-stabilizerstate-6ef8790c765690c1.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-equiv-stabilizerstate-6ef8790c765690c1.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Shelly! LGTM, though best to check to @jakelishman or @ikkoham to see if they have any further comments,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shelly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late. LGTM, but I have some minor comments.
f6ea486
7ad4fde
to
f6ea486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. LGTM!
* add equiv method to StabilizerState class * add a test for equiv method * add release notes * add explanantion to the tests * update comment in tests * updates following review * update exp_val calculation * updates following review --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
Add an
equiv
method to theStabilizerState
class, that checks if the generating sets of two stabilizer states generate the same stabilizer group.close #9338
Details and comments