Update Target to use CalibrationEntry to create inst map #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstructionProperties._calibration now only takes CalibrationEntry and use this instance to create an inst map.
nkanazawa1989
added
the
Changelog: Bugfix
nkanazawa1989
requested review from
a team,
eggerdj and
wshanks
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4204268420
💛 - Coveralls |
mtreinish
added
the
stable backport potential
mtreinish
reviewed
Feb 16, 2023
releasenotes/notes/fix-instmap-from-target-f38962c3fd03e5d3.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
nkanazawa1989
force-pushed
the
fix/inst-map-from-target
branch
from
2367db6
to
292fabd
Compare
mtreinish
approved these changes
Feb 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Bug fix for InstructionScheduleMap.has_custom_gate. InstructionProperties._calibration now only takes CalibrationEntry and use this instance to create an inst map. * Fix repr not to call .calibration * Review comment Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Remove getattr --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ecb6f9a)
mergify bot
added a commit
that referenced
this pull request
Feb 17, 2023
* Bug fix for InstructionScheduleMap.has_custom_gate. InstructionProperties._calibration now only takes CalibrationEntry and use this instance to create an inst map. * Fix repr not to call .calibration * Review comment Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Remove getattr --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ecb6f9a) Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug that
InstructionScheduleMap.has_custom_gate()always return True when the inst map is created byTarget.instruction_schedule_map.In previous implementation,
.get_schedule()method is called viaInstructionProperties.calibration, which generates a schedule fromPulseQobjDef, to create an inst map. In this PR,Target.instruction_schedule_mapis updated to bypassget_schedulecall to keepPulseQobjDefun-parsed.Fix #9595
Details and comments
InstructionProperties._calibrationis updated to only storeCalibrationEntry, which was previouslyUnion[CalibrationEntry, Schedule, ScheduleBlock].