-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_trials
parameter to VF2PostLayout
.
#9963
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
I've tagged this as being part of the 0.24.0 as a feature freeze exception. This extra flag for |
releasenotes/notes/vf2-post-layout-max-trials-98b1c736e2e33861.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 4694176989
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release note LGTM, just one small inline comment. After that I think we're good to merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick updates.
* Add max_trials parameter to VF2PostLayout. * Fix formatting. * Fix spacing. * Update release note based on review. * Revert vf2_layout.py.
* Add max_trials parameter to VF2PostLayout. * Fix formatting. * Fix spacing. * Update release note based on review. * Revert vf2_layout.py.
Summary
Adds a new parameter
max_trials
to passVF2PostLayout
which, when specified, limits the number of layouts discovered and compared when searching for the best layout.This can be used to place an upper bound on the time spent scoring potential layouts, which may be useful for larger devices. In a follow-up PR, we'll specify the parameter accordingly when invoking VF2 post layout within the preset pass managers.